Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7125] Remove extension-refresh feature flag from clients #13450

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7125

📔 Objective

With the removal of the last usage of the extension-refresh-feature flag (#13449), this flag can finally be removed from clients.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.29%. Comparing base (d2b0928) to head (fe7754d).
Report is 31 commits behind head on arch/remove-nord-solarize.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           arch/remove-nord-solarize   #13450      +/-   ##
=============================================================
- Coverage                      35.29%   35.29%   -0.01%     
=============================================================
  Files                           3125     3125              
  Lines                          92572    92571       -1     
  Branches                       16799    16799              
=============================================================
- Hits                           32673    32672       -1     
  Misses                         57459    57459              
  Partials                        2440     2440              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1dd7abdb-9626-4c16-be44-f79194b3e9be

Great job, no security vulnerabilities found in this Pull Request

@djsmith85 djsmith85 merged commit c042204 into arch/remove-nord-solarize Feb 20, 2025
92 of 93 checks passed
@djsmith85 djsmith85 deleted the vault/pm-7125/remove-extension-refresh-feature-flag branch February 20, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants