Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7125] Remove extension-refresh feature flag #5410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7125

📔 Objective

With the removal of the last usage of the extension-refresh-feature flag (bitwarden/clients#13449), this flag can finally be removed from clients.

Depends on bitwarden/clients#13450 and bitwarden/clients#13449 on clients merging

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 added the hold Hold this PR or item until later; DO NOT MERGE label Feb 17, 2025
@djsmith85 djsmith85 requested review from a team and shane-melton February 17, 2025 14:40
Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
extension-refresh extension-refresh ✅ all references removed

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.51%. Comparing base (f80acae) to head (1adbf11).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5410   +/-   ##
=======================================
  Coverage   44.51%   44.51%           
=======================================
  Files        1507     1507           
  Lines       69998    69998           
  Branches     6301     6301           
=======================================
  Hits        31161    31161           
  Misses      37504    37504           
  Partials     1333     1333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details67fc7536-b042-4c31-a7f3-23964268cbaf

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-flag hold Hold this PR or item until later; DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant