Pull from upstream master #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves dns server out of webportal setup as it is only needed for softap and captive portal, still enabled for portal so cp can be toggled on and off
Replaces root WiFiManager title with cusotm as well as page title, Also swaps headers, title first then domain - ip
fix potential memory leak in WiFiManagerParameter::setValue
* refactor strings, split out consts breaking! * move consts out of strings file BREAKING You will have to remove the constants from your strings files and add the new include instead, a simple diff should obviously show the changes * adds WM_STRINGS_FILE for env overrides * Revert "move consts out of strings file BREAKING" This reverts commit bb9f092. * Create wm_strings_en.h * final clean up of strings_en.h, legacy * comments
I will add esp detection for this stuff before readding
add strings file `build_flags = -DWM_DEBUG_PORT=Serial -DWM_DEBUG_LEVEL=4 -DWM_STRINGS_FILE="\"wm_strings_es.h\""`
menutokens pointers not actually in progmem
dirty fix, will have to add proper flashstring helper casts instead probably
Change `REQUIRES` to `PRIV_REQUIRES` because the public API of this package does not require users of this package to know about `arduino`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think there are some changes in upstream that fix compatibility issues with more recent versions of the Arduino SDK:
tzapu#645
I think when we started using the fork it was because the WiFiManager project had plans to add the features you needed, but weren't able to merge them in quickly. Is it still the case that they don't have the features we need?