Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send cancels even if peer has no interest #829

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Feb 3, 2025

Possible fix for memory leak in wantlists.

It appears necessary to send cancels even if the receiving peer has no interest in the CIDs according to the session interest manager. The handling of cancels cleans up the CIDs that remain on the peerwantmanager wantlists.

@gammazero gammazero requested a review from a team as a code owner February 3, 2025 07:59
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.43%. Comparing base (49f6c15) to head (f4b6a03).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   60.46%   60.43%   -0.04%     
==========================================
  Files         244      244              
  Lines       31121    31125       +4     
==========================================
- Hits        18817    18810       -7     
- Misses      10626    10634       +8     
- Partials     1678     1681       +3     
Files with missing lines Coverage Δ
...tswap/client/internal/messagequeue/messagequeue.go 85.42% <ø> (+1.30%) ⬆️
...p/client/internal/sessionmanager/sessionmanager.go 96.15% <100.00%> (+0.15%) ⬆️

... and 10 files with indirect coverage changes

Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick

@gammazero gammazero marked this pull request as draft February 3, 2025 15:36
@gammazero gammazero marked this pull request as ready for review February 4, 2025 00:12
@gammazero gammazero merged commit 9e257a7 into main Feb 4, 2025
15 checks passed
@gammazero gammazero deleted the always-send-cancels branch February 4, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants