fix(bitswap): blockpresencemanager leak #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BlockPresenceManager
leak uncovered by @Wondertan in 7adce5fcancel
(as introduced in Always send cancels even if peer has no interest #829)Reasoning
cancel
was sent directly after receiving a block.wanted
keys. IIUC the filtering (inSessionsInterestManager
) doesn't use thePeerManager
wantlist.@gammazero I suspect this PR is equivalent to #829 wrt. sending Cancels, although we don't send cancels for blocks we don't want. I suggest we run a short test to be convinced of it before merging.