Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap): blockpresencemanager leak #833

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

guillaumemichel
Copy link
Contributor

Summary

Reasoning

@gammazero I suspect this PR is equivalent to #829 wrt. sending Cancels, although we don't send cancels for blocks we don't want. I suggest we run a short test to be convinced of it before merging.

@guillaumemichel guillaumemichel requested a review from a team as a code owner February 4, 2025 12:26
@guillaumemichel guillaumemichel force-pushed the fix/blockpresencemanager-leak branch from e854475 to e34cfd8 Compare February 4, 2025 12:28
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (9e257a7) to head (e34cfd8).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   60.44%   60.48%   +0.04%     
==========================================
  Files         244      244              
  Lines       31125    31120       -5     
==========================================
+ Hits        18812    18822      +10     
+ Misses      10630    10622       -8     
+ Partials     1683     1676       -7     
Files with missing lines Coverage Δ
bitswap/client/internal/session/session.go 90.56% <100.00%> (+0.37%) ⬆️
...p/client/internal/sessionmanager/sessionmanager.go 95.95% <ø> (-0.20%) ⬇️

... and 9 files with indirect coverage changes

@lidel lidel requested a review from gammazero February 4, 2025 15:29
@lidel lidel mentioned this pull request Feb 4, 2025
32 tasks
@gammazero gammazero merged commit 1ff84ce into main Feb 4, 2025
15 checks passed
@gammazero gammazero deleted the fix/blockpresencemanager-leak branch February 4, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants