Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8gb design diagrams with clear k8gb controller location #602

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Update k8gb design diagrams with clear k8gb controller location #602

merged 1 commit into from
Sep 7, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Sep 7, 2021

Resolves #598

Signed-off-by: Yury Tsarev [email protected]

k0da
k0da requested changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please push svgs as well

@ytsarev
Copy link
Member Author

ytsarev commented Sep 7, 2021

@k0da I'm pretty sure I did
image

@ytsarev ytsarev requested a review from k0da September 7, 2021 09:17
k0da
k0da approved these changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see it, thanks

@ytsarev ytsarev merged commit b043228 into master Sep 7, 2021
@ytsarev ytsarev deleted the diagrams branch September 7, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser is a code owner

@kuritka kuritka Awaiting requested review from kuritka kuritka is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update diagrams in a Concepts documentation section
2 participants
@ytsarev @k0da