-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terratest readable output #826
Terratest readable output #826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AugustasV thanks a lot for your contribution.
We also have .github/workflows/upgrade-testing.yaml
which involves terratest execution so it is a candidate for the enhancement.
Please also sign off the commits to satisfy DCO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! pls see the comments, otherwise it looks good
dd86134
to
58fa005
Compare
03bc83b
to
3245aab
Compare
cool 💯 , I can see the uploaded zip file with the separated log files: https://github.com/k8gb-io/k8gb/actions/runs/1664623772 Could you pls add one more thing? The link that would lead to that web page where it can be get. this should be the filed -
to Terratest log parser step example for PR msg: and it then looks like this: Another future improvement could be actually printing these logs right away during the build, but let's not complicate it even more. There is a way to make the collapsible log sections like in TravisCi - https://github.yoyoweb123.workers.devmunity/t/has-github-action-somthing-like-travis-fold/16841 so then having something like Terratest logs:
▶ TestK8gbSplitFailoverExample
▶ TestK8gbIngressAnnotationRR
.. would be awesome |
a430ccc
to
3f5d741
Compare
right, nice so it works almost :D, I think we need to iterate through the files one by one and "cat"em within each collapsible section, check the suggestion comments with the diff I've made as for the DCO check, could you pls sign them all? It's still possible with interactive rebase(tutorial). Or you can make your life easier and squash all the commits to just one, up to you, or we can squash it during the PR merge using "github button". Otherwise some tips for signing are also here: https://github.com/k8gb-io/k8gb/blob/master/CONTRIBUTING.md#signature |
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: AugustasV <[email protected]>
Signed-off-by: Jirka Kremser <[email protected]> Signed-off-by: AugustasV <[email protected]>
Co-authored-by: Jirka Kremser <[email protected]> Signed-off-by: AugustasV <[email protected]>
Co-authored-by: Jirka Kremser <[email protected]> Signed-off-by: AugustasV <[email protected]>
069cf73
to
0a4d975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, DCO is passing, we are almost there
5512a41
to
825f732
Compare
… into terratest_readable_output Signed-off-by: AugustasV <[email protected]>
825f732
to
16506d6
Compare
… into terratest_readable_output Signed-off-by: AugustasV <[email protected]>
… into terratest_readable_output Signed-off-by: AugustasV <[email protected]>
b43bef7
to
3608be5
Compare
I see that my all DCO signed with |
Signed-off-by: AugustasV <[email protected]>
3608be5
to
d8ab44a
Compare
#825 Updated make file and terratest files to output terratest results.
In that way it will be easier to debug.