Validation for strategy type #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strategies are not validated. I am adding validation to the strategy type. Signed-off-by: kuritka <[email protected]>
kuritka
requested review from
donovanmuller,
k0da,
somaritane,
ytsarev and
jkremser
as code owners
ytsarev
approved these changes
Jun 16, 2022
|
Looks great! |
kuritka
added a commit
that referenced
this pull request
Jun 22, 2022
Test no.1 calling Do weight annotation test 123 test- fails on depresolver blocker Validation for strategy type (#906) Strategies are not validated. I am adding validation to the strategy type. Signed-off-by: kuritka <[email protected]> Extract depresolver interface close #908 - extracting interface GslbResolver - GslbResolver Mock - refactor Reconciler Signed-off-by: kuritka <[email protected]> update test Extract depresolver interface (#910) close #908 - extracting interface GslbResolver - GslbResolver Mock - refactor Reconciler Signed-off-by: kuritka <[email protected]> Weight Round Robin - annotations tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strategies are not validated. I am adding validation to the strategy type.
Signed-off-by: kuritka [email protected]