Make the ruby_runtime() rule re-load if PATH changes. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make `rvm use` commands take effect immediately, rather than requiring a `blaze clean --expunge` first. This has an unfortunate side-effect of also forcing a re-download of hermetic Ruby versions when PATH changes. To fix this, we should make `system_ruby()` its own repository rule, so that hermetic Ruby versions are not affected by PATH.
mkruskal-google
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
rvm usecommands take effect immediately, rather than requiring ablaze clean --expungefirst.This has an unfortunate side-effect of also forcing a re-download of hermetic Ruby versions when PATH changes. To fix this, we should make
system_ruby()its own repository rule, so that hermetic Ruby versions are not affected by PATH.