Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ruby_runtime() rule re-load if PATH changes. #22

Merged
merged 1 commit into from
Feb 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ruby/private/toolchains/ruby_runtime.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -331,4 +331,9 @@ ruby_runtime = repository_rule(
allow_single_file = True,
),
},
# Force a re-fetch when the Ruby version is changed through RVM.
# This will also force a re-download when PATH changes, which is
# unnecessary. To fix this, we may want to make system_ruby()
# a different repository rule from ruby_runtime().
environ = ["PATH"],
)