Skip to content
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.

Equipment Import broken #1140

Closed
Closed
@orenyk

Description

@orenyk

We broke equipment import with both the rubocop changes (#1075) and the notes (#273). I haven't debugged things fully, but here's what I've found so far:

  1. The accepted_keys order in EquipmentImport#valid_cat_import? was changed from what we have documented (I believe to fit things to 80 characters nicely).
  2. We're using update_attributes to create the new equipment objects in EquipmentImport#import_objects but this fails since we're not specifying notes in our parameters and there's no default value defined. We should use assign_attributes instead.

There's probably other stuff, we should test that this is working again and fix any other issues. Tbh, writing some tests wouldn't hurt as well :-P.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions