This repository was archived by the owner on Jul 24, 2020. It is now read-only.
This repository was archived by the owner on Jul 24, 2020. It is now read-only.
Equipment Import broken #1140
Closed
Description
We broke equipment import with both the rubocop changes (#1075) and the notes (#273). I haven't debugged things fully, but here's what I've found so far:
- The
accepted_keys
order inEquipmentImport#valid_cat_import?
was changed from what we have documented (I believe to fit things to 80 characters nicely). - We're using
update_attributes
to create the new equipment objects inEquipmentImport#import_objects
but this fails since we're not specifyingnotes
in our parameters and there's no default value defined. We should useassign_attributes
instead.
There's probably other stuff, we should test that this is working again and fix any other issues. Tbh, writing some tests wouldn't hurt as well :-P.
Activity